Skip to content

GrpcWebClientBase: clean up !useUnaryResponse callback args #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

GrpcWebClientBase: clean up !useUnaryResponse callback args #1297

merged 1 commit into from
Oct 26, 2022

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Oct 25, 2022

from #1230, the public rpcCall allows users to provide a callback which is documented only to take 2 parameters. avoid passing the extra unaryResponseReceived flag in that case

@pro-wh pro-wh mentioned this pull request Oct 25, 2022
Merged
sampajano
sampajano approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for cleaning this up! 😃

@sampajano sampajano merged commit 6577c66 into grpc:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampajano sampajano sampajano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pro-wh @sampajano @grpc-kokoro