Allow for custom install prefix #1107
Conversation
637a576 to
b0803be
Compare
|
@stanley-cheung @sampajano Please can I get a review on this This is required for us to easily package this for nixpkgs https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/tools/protoc-gen-grpc-web/default.nix#L16-L25 |
javascript/net/grpc/web/Makefile
Outdated
|
|
||
| all: protoc-gen-grpc-web | ||
|
|
||
| protoc-gen-grpc-web: grpc_generator.o | ||
| $(CXX) $^ $(LDFLAGS) -o $@ | ||
|
|
||
| install: protoc-gen-grpc-web | ||
| install protoc-gen-grpc-web /usr/local/bin/protoc-gen-grpc-web | ||
| install -Dm755 protoc-gen-grpc-web $(PREFIX)/bin/protoc-gen-grpc-web |
There was a problem hiding this comment.
I don't think -Dm755 work on macOS (BSD) version of install..
Is there a way you can make this work for both? :)
(Also from what i read 755 is the default so i'm curious why you'd need to specify it?)
There was a problem hiding this comment.
Can we leave this -Dm755 out and just use the system default? the PREFIX change looks good.
There was a problem hiding this comment.
I can either drop it or add a mkdir -p $(PREFIX)/bin above install
There was a problem hiding this comment.
Yeah this is cool with me.. But i'll defer to @stanley-cheung's for approval :)
Thanks for the change :)
There was a problem hiding this comment.
Yes mkdir sounds good. thanks.
Also create the dir if it doesn't exist
b0803be to
2351731
Compare
Allow for custom install prefix
Also create the dir if it doesn't exist and ensure 755 perms