Internal code sync #1082

stanley-cheung · 2021-05-12T21:54:16Z

Jennnnny

The generated code with non-closure mode still has MethodInfo so it will definitely break some users.... I think we should update grpc_generator.cc before merging as well(I have a cl for review in critique).

stanley-cheung · 2021-05-12T22:11:50Z

Sounds good. Part of the reason I want to create this PR is to make sure there is no outstanding unmerged (to google3) changes in grpc_generator.cc. Looks like there's none. So we can safely update grpc_generator.cc in google3 now.

stanley-cheung · 2021-05-13T00:59:19Z

I patched in the grpc_generator.cc change to get rid of some errors related to the generated code still having reference to MethodInfo. Now those errors are gone.

But now bazel test //javascript/net/grpc/web/... failed but I couldn't find any meaningful error log even when running the test locally. They just failed

Executing tests from //javascript/net/grpc/web:grpcwebclientbase_test
-----------------------------------------------------------------------------
Listening http://localhost:46452/index.html
Serving /index.html
Serving /filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js
Serving /filez/io_bazel_rules_closure/closure/testing/phantomjs_jsunit_runner.js
-> 00:57:40.053 : Starting tests: Untitled Test Case
-> 00:57:40.053 : Running test: testDeadline
-> $$JSCompiler_prototypeAlias$$$$getStreamingResponseHeader$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2808:48
-> http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2363:101
$JSCompiler_StaticMethods_fireListeners$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1803:59
$JSCompiler_StaticMethods_goog_events_EventTarget_prototype$dispatchEvent$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1785:111
$JSCompiler_StaticMethods_simulateReadyStateChange$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2726:157
$$JSCompiler_prototypeAlias$$$$goog_net_XhrIo_prototype$send$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2713:55
$JSCompiler_StaticMethods_startStream_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2618:68
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2520:52
$$module$contents$grpc$web$GrpcWebClientBase_GrpcWebClientBase$$$$$rpcCall$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2521:20
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4232:37
$PolyfillPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:225:18
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4231:200
$JSCompiler_StaticMethods_nextStep_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:124:99
$this$next$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:146:418
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:172:56
$PolyfillPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:225:18
$$jscomp$asyncExecutePromiseGenerator$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:168:21
$$jscomp$asyncExecutePromiseGeneratorProgram$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:176:49
testDeadline@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4227:56
[native code]
$$JSCompiler_prototypeAlias$$$$invokeFunction_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3676:50
$$JSCompiler_prototypeAlias$$$$safeRunTest_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3663:32
$$JSCompiler_prototypeAlias$$$$safeRunTest_$$@[native code]
$goog$testing$Continuation_$run$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3963:96
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3595:324
[native code]
$goog$testing$Continuation_$run$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3963:96
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3594:38
$goog$Promise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1224:32
$JSCompiler_StaticMethods_runTestsReturningPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3593:22
$JSCompiler_StaticMethods_goog_testing_TestRunner_prototype$execute$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4041:184
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4185:78
-> 00:57:40.059 : testDeadline : FAILED

Here's roughly how to reproduce locally:

$ <patch in this PR>
$ docker-compose build common prereqs
$ docker run -it --rm grpcweb/prereqs /bin/bash
$ <now inside the docker image> bazel test --cache_test_results=no //javascript/net/grpc/web/...

Jennnnny · 2021-05-14T05:09:33Z

I patched in the grpc_generator.cc change to get rid of some errors related to the generated code still having reference to MethodInfo. Now those errors are gone.

But now bazel test //javascript/net/grpc/web/... failed but I couldn't find any meaningful error log even when running the test locally. They just failed

Executing tests from //javascript/net/grpc/web:grpcwebclientbase_test
-----------------------------------------------------------------------------
Listening http://localhost:46452/index.html
Serving /index.html
Serving /filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js
Serving /filez/io_bazel_rules_closure/closure/testing/phantomjs_jsunit_runner.js
-> 00:57:40.053 : Starting tests: Untitled Test Case
-> 00:57:40.053 : Running test: testDeadline
-> $$JSCompiler_prototypeAlias$$$$getStreamingResponseHeader$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2808:48
-> http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2363:101
$JSCompiler_StaticMethods_fireListeners$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1803:59
$JSCompiler_StaticMethods_goog_events_EventTarget_prototype$dispatchEvent$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1785:111
$JSCompiler_StaticMethods_simulateReadyStateChange$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2726:157
$$JSCompiler_prototypeAlias$$$$goog_net_XhrIo_prototype$send$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2713:55
$JSCompiler_StaticMethods_startStream_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2618:68
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2520:52
$$module$contents$grpc$web$GrpcWebClientBase_GrpcWebClientBase$$$$$rpcCall$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:2521:20
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4232:37
$PolyfillPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:225:18
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4231:200
$JSCompiler_StaticMethods_nextStep_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:124:99
$this$next$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:146:418
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:172:56
$PolyfillPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:225:18
$$jscomp$asyncExecutePromiseGenerator$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:168:21
$$jscomp$asyncExecutePromiseGeneratorProgram$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:176:49
testDeadline@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4227:56
[native code]
$$JSCompiler_prototypeAlias$$$$invokeFunction_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3676:50
$$JSCompiler_prototypeAlias$$$$safeRunTest_$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3663:32
$$JSCompiler_prototypeAlias$$$$safeRunTest_$$@[native code]
$goog$testing$Continuation_$run$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3963:96
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3595:324
[native code]
$goog$testing$Continuation_$run$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3963:96
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3594:38
$goog$Promise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:1224:32
$JSCompiler_StaticMethods_runTestsReturningPromise$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:3593:22
$JSCompiler_StaticMethods_goog_testing_TestRunner_prototype$execute$$@http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4041:184
http://localhost:46452/filez/com_github_grpc_grpc_web/javascript/net/grpc/web/grpcwebclientbase_test_bin.js:4185:78
-> 00:57:40.059 : testDeadline : FAILED

Here's roughly how to reproduce locally:

$ <patch in this PR>
$ docker-compose build common prereqs
$ docker run -it --rm grpcweb/prereqs /bin/bash
$ <now inside the docker image> bazel test --cache_test_results=no //javascript/net/grpc/web/...

Oh man..I guess I know why this fails. I submitted a cl/371207002 internally to fix the closure testing xhrIo..seems like it is not updated in open source? I saw the first line of the error message is "getStreamingResponseHeader, which is what I fixed in closure lib.

stanley-cheung · 2021-05-17T04:51:18Z

I see. Our grpc-web third_party/closure-library link is currently at v20201102 released on Nov 17, 2020. Your fix was merged late Apr 2021 so we should watch out for the next 2021 May release to see if your fix is included in there.

stanley-cheung · 2021-08-03T21:27:51Z

This is getting out of hand. will start to bisect from an older state to see if we can isolate which internal CL causes these errors.

stanley-cheung requested a review from Jennnnny May 12, 2021 21:54

Jennnnny reviewed May 12, 2021

View reviewed changes

stanley-cheung added 7 commits August 3, 2021 13:44

Internal code sync

a46d2a9

Fix BUILD.bazel

32562ac

Fix BUILD.bazel

1def308

Add changes to grpc_generator.cc as well

795395e

Update third_party/closure-library v20210601

62fe3fb

Update init_submodules script too

6db3238

more code sync

6cee2fa

stanley-cheung force-pushed the internal-code-sync branch from 3921d6a to 6cee2fa Compare August 3, 2021 20:47

stanley-cheung closed this Aug 3, 2021

stanley-cheung deleted the internal-code-sync branch August 3, 2021 21:38

stanley-cheung mentioned this pull request Sep 22, 2021

Remove Bazel in Javascript toolchain #1138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Internal code sync #1082

Internal code sync #1082

Uh oh!

stanley-cheung commented May 12, 2021

Uh oh!

Jennnnny left a comment

Uh oh!

stanley-cheung commented May 12, 2021

Uh oh!

stanley-cheung commented May 13, 2021 •

edited

Loading

Uh oh!

Jennnnny commented May 14, 2021

Uh oh!

stanley-cheung commented May 17, 2021

Uh oh!

stanley-cheung commented Aug 3, 2021

Uh oh!

Uh oh!

Internal code sync #1082

Internal code sync #1082

Uh oh!

Conversation

stanley-cheung commented May 12, 2021

Uh oh!

Jennnnny left a comment

Choose a reason for hiding this comment

Uh oh!

stanley-cheung commented May 12, 2021

Uh oh!

stanley-cheung commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jennnnny commented May 14, 2021

Uh oh!

stanley-cheung commented May 17, 2021

Uh oh!

stanley-cheung commented Aug 3, 2021

Uh oh!

Uh oh!

stanley-cheung commented May 13, 2021 •

edited

Loading