[bazel] Update rules_closure + fix linter warnings #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gattytto Yes, this alone doesn't fix #575 / bazelbuild/rules_closure#390 yet (which is the underlying issue to what you're seeing). There is a bit of plumbing required that has been stuck in review for ages: bazelbuild/rules_proto#22. I'm trying to get that prioritized so we can get a fix for #575 soon, but I can't promise any concrete timeline, sorry. |
|
@Yannic thank you for the quick response, I'll subscribe to the issues so I get notifications when they get fixed. 👍 |
stanley-cheung
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
@Yannic Thanks for the contributions to the bazel toolchain, as usual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards resolving #744, #575, #550, #700