Skip to content

Conversation

grll
Copy link
Owner

@grll grll commented Mar 28, 2025

  • fix exec security risk
  • simplify by directly forwarding the input json schema
  • might also fix other issue linked to json_schema -> python like AnyOf...

@grll
Copy link
Owner Author

grll commented Mar 28, 2025

@tisDDM sorry for the late reply can you have a look at this one? We have to remove the exec code as it opens a security risk for MCP server over SSE. It should also fix the AnyOf issues and order of parameters / default parameters. The idea is to directly forward the input json_schema from the mcp server to smolagents system prompt. No more python in between.

Let me know what you think.

@grll
Copy link
Owner Author

grll commented Mar 28, 2025

fix #16

@grll
Copy link
Owner Author

grll commented Mar 28, 2025

fix #19

@grll
Copy link
Owner Author

grll commented Mar 28, 2025

fix #15

@grll
Copy link
Owner Author

grll commented Mar 28, 2025

fix huggingface/smolagents#1085

@tisDDM
Copy link

tisDDM commented Mar 29, 2025

@grll I had a quick look, and I think the idea is very good and much cleaner as before. I will give it a deeper look and test it in the next few days though I am also a bit occupied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants