Skip to content

Access task locals from asynchronous database accesses #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 19, 2025
Merged

Access task locals from asynchronous database accesses #1794

merged 21 commits into from
Jul 19, 2025

Conversation

groue
Copy link
Owner

@groue groue commented Jul 17, 2025 •
edited
Loading

As discussed in #1793, users want to access task locals from within async database accesses. This PR aims at fulfilling this feature request.

let dbQueue = try DatabaseQueue()

@TaskLocal var myLocal = 0
try await $myLocal.withValue(42) {
  try await dbQueue.read { db in
    print(myLocal) // prints 42
  }
}

@groue groue force-pushed the dev/actor-access branch 2 times, most recently from 257dce1 to ff1566b Compare July 19, 2025 09:41
groue added 15 commits July 19, 2025 14:25
@groue
Failing test for task locals (#1793)
01cd49b
@groue
Turn Database.cancel into a sendable closure
96236a3
@groue
DatabaseQueue and DatabaseSnapshot reads can access task locals
c064515
@groue
Extract DispatchQueueActor
e684788 
We'll probably need it in order to access pool elements with support for task locals
@groue
Async version of Pool.get()
27b7400
@groue
DatabasePool reads can access task locals
41d4f23
@groue
Don't check for reentrancy from async Pool.read
e154a65 
One can't call an async function from a database access anywau
@groue
DatabaseSnapshotPool reads can access task locals
c5ac6cd
@groue
Add failing test for task locals access from unsafeRead (#1793)
9dd8b2c
@groue
Allow COMMIT from a cancelled read-only access.
69b786d
@groue
DatabasePool unsafeRead can access task locals
dd42273
@groue
Add asserts about expected ends of transaction
cbbd0cb
@groue
Failing test for task locals with DatabaseWriter (#1793)
b24fb76
@groue
DispatchQueueActor supports barriers in concurrent DispatchQueue
684266b
@groue
Async version of Pool.barrier { ... }
a703da9
@groue groue force-pushed the dev/actor-access branch 2 times, most recently from 9eb4cec to 2184cf6 Compare July 19, 2025 13:04
@groue groue force-pushed the dev/actor-access branch from 2184cf6 to 7a1e65b Compare July 19, 2025 13:29
@groue groue merged commit 3f928bc into development Jul 19, 2025
8 checks passed
@groue groue deleted the dev/actor-access branch July 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@groue