Fix DatabaseMigrator.hasSchemaChanges failing for readonly connections #1653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5c9459 to
a741fb3
Compare
|
Thanks @Jnosh for this quality PR! 👍 I should be able to merge tomorrow. |
|
⛵ Shipped in v7.0.0-beta.5 :-) Would you accept an invitation that grants you a push access to GRDB? I do intend to keep the lead of the project, but it is good for everyone that people of various levels of expertise can improve the repository. Of course, your free time would remain just as free as it was before! |
Sure, I'd be honored to accept! <3 |
|
Woot! Done. Be welcome, @Jnosh :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseMigrator.hasSchemaChangescurrently fails for readonly database configurations. This wasn't an issue before since the migrator needed write access to perform migrations anyway.With the introduction of
hasSchemaChangesthis becomes an issue when:DatabasePool.readwhich always uses a readonly connection even when the DB is opened as writeableThis PR fixes that issue by adjusting the database configuration used by the migrator to create the temporary database in
hasSchemaChanges.developmentbranch.make smokeTestterminal command runs without failure.