Skip to content

Conversation

jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Oct 7, 2024

What does this PR do?

Change our circleci config to temporarily release from this branch instead of master

Where should the reviewer start?

What testing has been done on this PR?

How should this be manually tested?

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Do the grommet docs need to be updated?

Should this PR be mentioned in the release notes?

Is this change backwards compatible or is it a breaking change?

@jcfilben jcfilben merged commit 0086f74 into react-compatibility Oct 7, 2024
10 checks passed
@jcfilben jcfilben deleted the change-release-branch branch October 7, 2024 21:52
@jcfilben jcfilben restored the change-release-branch branch October 7, 2024 22:26
jcfilben added a commit that referenced this pull request Oct 9, 2024
* Change release branch (#7346)

* Accordion - Replace useId (#7345)

* Replace useId function

* address review comments

* changed comment to re-trigger circleci run

* Updated v2.40.2

* change release step in circleci to point back to master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants