Accordion - Replace useId #7345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
taysea
reviewed
Oct 7, 2024
| @@ -19,6 +19,16 @@ const customTheme = { | |||
| }; | |||
|
|
|||
| describe('Accordion', () => { | |||
| beforeEach(() => { | |||
| jest.spyOn(Date, 'now').mockImplementation(() => 12345678); | |||
| jest.spyOn(global.Math, 'random').mockReturnValue(0.123456789); | |||
There was a problem hiding this comment.
Can you add comments about how you chose the values here?
There was a problem hiding this comment.
Added a comment in latest commit
taysea
reviewed
Oct 7, 2024
| // Ideally we should use `useId` from react but this is only available | ||
| // in React 18 and we want to keep compatibility with React 17 and 16. | ||
| function getUID() { | ||
| const timestamp = Date.now().toString(36); |
There was a problem hiding this comment.
Should we do:
Date.now() + Math.random() instead of just appending Math.random?
There was a problem hiding this comment.
Changed in latest commit
16 tasks
taysea
approved these changes
Oct 7, 2024
britt6612
approved these changes
Oct 7, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces useId in AccordionPanel because useId is only available in React 18 and we need to support react 16 and 17 as well.
This PR is targeted to merge into the react-compatibility branh so we can do a patch release from that branch
Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible