Enhance DataTableColumns ordering options #7193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial, draft, PR to enhance DataTableColumns to disallow changing the order of selected columns. This PR addresses this issue: grommet#7170 A new attribute, pinOrder, can be specified in an object in the options property. This attribute pins the order of this column in DataTableColumns. This is implemented using the existing pinned property of the List component. Here is a description of requirements provided by Taylor Seamans: 1. Whichever item is effectively the “first” reorderable item should have the up arrow button disabled 2. If an item that isn’t the leftmost is not reorderable, then the items around it should shift while keeping its order fixed 3. This behavior should work for both drag + drop as well as using the arrow keys
|
Screenshot after renaming |
3 tasks
…into pin-column-order
2ec6422 to
410e583
Compare
|
@ganondev Similar to this test lmk if you need help! Also we decided on a styling but I will do those changes in a separate PR so we don't hold this up. |
taysea
reviewed
Apr 10, 2024
taysea
reviewed
Apr 10, 2024
taysea
reviewed
Apr 12, 2024
taysea
reviewed
Apr 12, 2024
taysea
reviewed
Apr 12, 2024
taysea
reviewed
Apr 12, 2024
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
taysea
reviewed
Apr 12, 2024
src/js/components/DataTableColumns/__tests__/DataTableColumns-test.tsx
Outdated
Show resolved
Hide resolved
…test.tsx Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
27 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clones #7178
This is a partial, draft, PR to enhance DataTableColumns to disallow changing the order of selected columns.
Closes #7170
A new attribute, pinOrder, can be specified in an object in the options property. This attribute pins the order of this column in DataTableColumns.
This is implemented using the existing pinned property of the List component.
Here is a description of requirements provided by Taylor Seamans:
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?