-
Notifications
You must be signed in to change notification settings - Fork 1k
Add check for responsive in roundStyle
#7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roundStyle
src/js/components/Skeleton/__tests__/__snapshots__/Skeleton-test.tsx.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In the PR description it says the docs do not need to be updated for this change but I think we would need to update the |
I can update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What does this PR do?
fixes Box
round
prop not respectingresponsive
Where should the reviewer start?
styles.js
What testing has been done on this PR?
locally
How should this be manually tested?
Do Jest tests follow these best practices?
screen
is used for querying.asFragment()
is used for snapshot testing.Any background context you want to provide?
see issue #6445
For Skeleton there was
${(props) => props.round && roundStyle(props.round, props.responsive, props.theme)}
however there is no responsive prop on Skeleton so just changed to
true
What are the relevant issues?
closes #6445
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible