Skip to content

Conversation

britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Mar 29, 2024

What does this PR do?

fixes Having a FormField with a null or false child

Where should the reviewer start?

formfield.js

What testing has been done on this PR?

storybook

How should this be manually tested?

<FormField>
        <TextInput />
        {false && <Text>foobar</Text>}
</FormField>

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

closes #7180

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

sure

Is this change backwards compatible or is it a breaking change?

backwards compatible

@britt6612 britt6612 requested a review from taysea March 29, 2024 19:28
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@taysea taysea requested a review from jcfilben April 4, 2024 15:59
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea merged commit 9c0d52a into grommet:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormField triggers errors when it has null as a child
3 participants