Fix autoFocusingTags regex #7174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
reviewed
Mar 26, 2024
| @@ -157,7 +157,7 @@ export const makeNodeFocusable = (node) => { | |||
| } | |||
| }; | |||
|
|
|||
| const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)$/; | |||
| const autoFocusingTags = /^(a|area|input|select|textarea|button|iframe)$/; | |||
There was a problem hiding this comment.
can we add a comment? just for future reference
maybe something like to avoid unintentionally matching <data and <meta tags we need the ^
There was a problem hiding this comment.
Added, though it's just essential regex knowledge
There was a problem hiding this comment.
thank you just good for some of us who would need to look this up and not known :)
Prevents unintentionally matching `data` and `meta` elements, and possibly custom web-components.
britt6612
approved these changes
Mar 26, 2024
taysea
approved these changes
Mar 27, 2024
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents unintentionally matching
dataandmetaelements, and possibly custom web-components.What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
<dataand<meta#6981Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
Not certain, but I doubt it affects any real-world usecase