Tag - add aria label for prop to remove button #7571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Apr 3, 2025
taysea
reviewed
Apr 3, 2025
MikeKingdom
reviewed
Apr 3, 2025
taysea
reviewed
Apr 4, 2025
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
taysea
reviewed
Apr 4, 2025
taysea
reviewed
Apr 4, 2025
taysea
reviewed
Apr 4, 2025
src/js/components/Tag/__tests__/__snapshots__/Tag-test.tsx.snap
Outdated
Show resolved
Hide resolved
taysea
reviewed
Apr 7, 2025
src/js/components/Data/__tests__/__snapshots__/Data-test.tsx.snap
Outdated
Show resolved
Hide resolved
MikeKingdom
reviewed
Apr 7, 2025
MikeKingdom
reviewed
Apr 8, 2025
src/js/components/Tag/index.d.ts
Outdated
| @@ -5,6 +5,9 @@ export interface TagProps { | |||
| name?: string; | |||
| onClick?: (...args: any[]) => any; | |||
| onRemove?: (...args: any[]) => any; | |||
| messages?: { | |||
| removeLabel?: string; | |||
There was a problem hiding this comment.
this needs to be updated for the new keys
src/js/components/Tag/propTypes.js
Outdated
| @@ -7,6 +7,9 @@ if (process.env.NODE_ENV !== 'production') { | |||
| value: PropTypes.string.isRequired, | |||
| onClick: PropTypes.func, | |||
| onRemove: PropTypes.func, | |||
| messages: PropTypes.shape({ | |||
| removeLabel: PropTypes.string, | |||
…aria-label-tag
…mmet into add-aria-label-tag
|
glad I added the tests. I saw that since |
Fair enough although I think that's a silly requirement and people tend to pick one or the other based on whether or not they want it to be bold. |
MikeKingdom
approved these changes
Apr 8, 2025
taysea
approved these changes
Apr 8, 2025
|
Holding off on merging until after the upcoming patch release |
|
Updated with master but looks like we need to bump the bundlesize up |
…aria-label-tag
…mmet into add-aria-label-tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a prop for
aria-labelto be passed inWhere should the reviewer start?
tag.js
What testing has been done on this PR?
locally
How should this be manually tested?
locally
Do Jest tests follow these best practices?
I didnt add one since it got added to other snapshots
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
On the Tag component there is no way for the implementer to provide an aria-label
What are the relevant issues?
closes #7555
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible