Select, SelectMultiple -- Add extend to listbox #7496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an extend to the theme for the "listbox" container directly surrounding the options. Open to naming suggestions, but things like "option.container" etc were already taken and apply to different things. "Listbox" is because this is the container with role="listbox".
Had to pass through
selectMultiple
as a prop on OptionsContainer so that the extend could differentiate between desired styling for Select vs SelectMultipleWhere should the reviewer start?
src/js/components/Select/StyledSelect.js
What testing has been done on this PR?
Locally. Also added jest tests.
How should this be manually tested?
Do Jest tests follow these best practices?
screen
is used for querying.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes.
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.