add option in anchor for gap per size #7491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Jan 28, 2025
jcfilben
reviewed
Jan 30, 2025
jcfilben
reviewed
Jan 30, 2025
| @@ -272,6 +285,11 @@ describe('Anchor', () => { | |||
| </Paragraph> | |||
| <Anchor label="Default anchor with no size prop should receive medium" /> | |||
| <Anchor label="Anchor with icon" icon={<LinkNext />} /> | |||
| <Anchor | |||
| label="Large anchor with icon should receive color on icon" | |||
There was a problem hiding this comment.
Should update the anchor name since it isn't a large anchor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
anchor.size.gapdefine a gap per anchor size.Where should the reviewer start?
Anchor.js
What testing has been done on this PR?
locally and test
How should this be manually tested?
locally
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
Right now, the gap between anchor label + icon can only be defined once (theme.anchor.gap) but it would be useful to be able to define a gap per anchor size.
What are the relevant issues?
closes #7477
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible