Add focus indicator theme option #7490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
commented
Jan 28, 2025
britt6612
commented
Jan 28, 2025
jcfilben
reviewed
Jan 28, 2025
jcfilben
reviewed
Jan 29, 2025
taysea
reviewed
Jan 30, 2025
Co-authored-by: Jessica Rosenquist <54560994+jcfilben@users.noreply.github.com>
Co-authored-by: Jessica Rosenquist <54560994+jcfilben@users.noreply.github.com>
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
taysea
reviewed
Jan 30, 2025
| return cloneElement(child, { | ||
| focusIndicator: modifiedFocusIndicator, | ||
| }); | ||
| } | ||
| return cloneElement(child, { | ||
| plain: true, | ||
| focusIndicator: false, |
There was a problem hiding this comment.
Could the above "if (wantFocusIndicator) condition be removed and just change the existing return to be:
return cloneElement(child, {
plain: true,
focusIndicator: theme.formField?.focus?.containerFocus === true ? false : true,
...
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
taysea
reviewed
Jan 30, 2025
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
taysea
approved these changes
Jan 30, 2025
|
I was just expecting the focus to change for these inputs I didn't expect the focus to change for inputs outside of this list when Previously: |
…britt6612/grommet into add-focusIndicator-theme-option
good catch @jcfilben fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an option in the theme to remove the
focusIndicatorfrom Formfield.Where should the reviewer start?
FormField.js
What testing has been done on this PR?
locally & wrote a test
test could use some work
How should this be manually tested?
locally
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
It's desirable to be able to set a flag in the theme to allow focus to be placed on the individual Checkbox/RadioButton/etc directly (following native browser behavior) rather than stealing it to place on formfield.
What are the relevant issues?
closes #7486
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible