add notification.message.fill #7488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Jan 27, 2025
MikeKingdom
reviewed
Jan 28, 2025
Comment on lines
178
to
182
| fill={ | ||
| Message === Paragraph | ||
| ? theme.notification.message?.fill || false | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
I'm trying to think of a cleaner way to do this. It seems pretty awkward to first set Message to Paragraph or Text and then compare against Paragraph here. I think it would at least be better to set up props at the same time you define whether it's Paragraph or Text. It would probably be cleaner to actually pull this up into a separate Message component.
There was a problem hiding this comment.
I can take a stab at making this a bit cleaner
MikeKingdom
reviewed
Jan 29, 2025
Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com>
Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com>
taysea
reviewed
Jan 30, 2025
taysea
approved these changes
Jan 30, 2025
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances Notification theme to be able to pass
fill: trueto the theme for when Paragraph is used.Where should the reviewer start?
notification.js
What testing has been done on this PR?
locally
How should this be manually tested?
locally
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
In cases where Notification direction is "column" (so the message renders as a paragraph), the theme should have the ability to set paragraph fill={true}.
What are the relevant issues?
closes #7485
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible