Skip to content

Add extend toggle group #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Conversation

britt6612
Copy link
Collaborator

What does this PR do?

Adds extend to toggleGroup

Where should the reviewer start?

styledToggleGroup

What testing has been done on this PR?

locally and wrote a test

How should this be manually tested?

locally

add

     extend: `
                border: 1px solid red;
                &:hover {
                  background-color: green;
                }
              `,

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

There is a desire to be able to provide hover styling on the container of the toggle group

What are the relevant issues?

closes #7481

Screenshots (if appropriate)

Do the grommet docs need to be updated?

yes

Should this PR be mentioned in the release notes?

yes

Is this change backwards compatible or is it a breaking change?

backwards compatible

@britt6612 britt6612 requested review from jcfilben and taysea January 27, 2025 19:41
@britt6612 britt6612 requested a review from jcfilben January 28, 2025 16:26
Copy link
Collaborator

@MikeKingdom MikeKingdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested it a bit also.

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcfilben jcfilben merged commit f212261 into grommet:master Jan 28, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToggleGroup -- enhance theme for container hover styling
3 participants