Calendar style a11y updates #7473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
reviewed
Jan 21, 2025
| @@ -708,7 +708,7 @@ const Calendar = forwardRef( | |||
| sizeProp={size} | |||
| fillContainer={fill} | |||
| > | |||
| <StyledDay otherMonth sizeProp={size} fillContainer={fill}> | |||
There was a problem hiding this comment.
why was this taken out?
There was a problem hiding this comment.
Previously the days of the week were receiving the otherMonth styling, but we don't want this to happen anymore and instead they should get the same styling as the regular days of the month.
There was a problem hiding this comment.
okay thank you for clarifying
britt6612
reviewed
Jan 21, 2025
| color: ${(props) => | ||
| normalizeColor( | ||
| props.otherMonth | ||
| ? props.theme.calendar?.day?.adjacent?.color || 'text-xweak' |
There was a problem hiding this comment.
think this naming makes sense
britt6612
approved these changes
Jan 21, 2025
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the Calendar styling to meet accessibility requirements. Based on work done in #7423.
The
calendar.day.adjacent.colortheme prop was added because in the HPE theme we want the calendar dates outside of the month to betext-weakinstead oftext-xweak.Open to naming suggestions on the theme prop. I went with the
adjacentnaming because this aligns with theshowAdjacentDaysprop on the Calendar component which controls if days outside of the month should be displayed or not.Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#7467
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible because previously we weren't meeting WCAG AA contrast requirements