Fix Star rating and thumb rating focus resolved by keyboard navigation #7466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
reviewed
Jan 10, 2025
britt6612
reviewed
Jan 13, 2025
britt6612
reviewed
Jan 13, 2025
britt6612
reviewed
Jan 13, 2025
britt6612
reviewed
Jan 14, 2025
britt6612
reviewed
Jan 14, 2025
| @@ -3,11 +3,14 @@ import { Star } from 'grommet-icons/icons/Star'; | |||
| import { StarOutline } from 'grommet-icons/icons/StarOutline'; | |||
| import { FormContext } from '../Form/FormContext'; | |||
| import { RadioButtonGroup } from '../RadioButtonGroup'; | |||
| import { StyledThumbsRatingBox } from '../ThumbsRating/ThumbsRating'; | |||
There was a problem hiding this comment.
can we also make StarRating its own box instead of importing StyledThumbsRatingBox
maybe StyledStarRatingBox that way incase we have styles that are specific to either component they are mutually exclusive.
|
@umeshiscreative |
91df026 to
01dddf0
Compare
|
@umeshiscreative code looks good trying to see why the there was a snap shot change though |
britt6612
reviewed
Jan 15, 2025
src/js/components/Accordion/__tests__/__snapshots__/Accordion-test.tsx.snap
Outdated
Show resolved
Hide resolved
britt6612
approved these changes
Jan 15, 2025
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Star rating and thumb rating focus resolved by keyboard navigation
Where should the reviewer start?
components/ThumbStarRating.js
components/StarRating.js
What testing has been done on this PR?
Updated Snapshot for this fix
How should this be manually tested?
Tested in Chromium based browser with storybook
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
Wrapping the StarRating and thumb rating component with StyledThumbratingBox
What are the relevant issues?
#7452 #7453
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
Not Sure