Detect React 18's useId directly rather than via import #7444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Kingdom <michael.kingdom@hpe.com>
|
TypeScript/CRA/grommet 2.42.0 app with React 17 before the fix: TypeScript/CRA/grommet 2.42.0 app with React 16 before the fix: |
jcfilben
approved these changes
Nov 22, 2024
taysea
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In grommet 2.42.0 we added a polyfill for React 18's
useId()for cases where React 16 or 17 were used. The way this polyfill was done still causes an error in when TypeScript is used due to it doing animport { useId } from 'react'.This change instead checks if useId is defined on the React module itself which seems to work better with TypeScript situations.
Fixes #7442
Where should the reviewer start?
utils/useId.js
What testing has been done on this PR?
Tested with a standalone TypeScript-based react project using React 16.
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#7442
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?