Fix List layout when it has action and onOrder defined #6350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
reviewed
Sep 23, 2022
jcfilben
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a List with both
actionandonOrderspecified the action and primary/secondary labels end up in a container that is column layout rather than the typical row layout you have withactionwhenonOrderisn't used.What does this PR do?
This change uses the same layout for the non onOrder-related elements as it would have used without
onOrder. In the case ofaction, this puts the action next to the onOrder controls more like you'd expect.Where should the reviewer start?
List.js
What testing has been done on this PR?
Manual, storybook and Jest
How should this be manually tested?
Manualy add an action to an onOrder example.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Fixes #6341
Screenshots (if appropriate)
Before:
After:
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
Backwards Compatible