<Data /> component, and friends #6343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool idea |
1 task
britt6612
reviewed
Dec 16, 2022
britt6612
reviewed
Dec 16, 2022
| test('renders', () => { | ||
| const { container } = render( | ||
| <Grommet> | ||
| <Data data={data}> |
There was a problem hiding this comment.
looks strange here like there is an extra gap
There was a problem hiding this comment.
but above you have gap='small' soo not sure what it could be
There was a problem hiding this comment.
Refactored Toolbar and the story.
There was a problem hiding this comment.
sounds good I can take a look
britt6612
reviewed
Dec 16, 2022
britt6612
reviewed
Dec 16, 2022
britt6612
reviewed
Dec 16, 2022
jcfilben
reviewed
Dec 20, 2022
britt6612
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exploration into adding a
Datacomponent.Simple
At it's simplest, one could do something like:
Preview
Variations
data driven containers
Substitute
ListorCardsforDataTable, or include them all, it works.Cardsis new here as well. See the stories under "Data" for examples.custom layout
New components include
DataSearch,DataFilters,DataFilter, andDataSummary. Using these within aDataallows the caller to customize the layout or various details. See the "Data/Inline" story for an example of a custom layoutwhere to put filters
DataFilterscan be shown inline, as thedropContentsof aDropButton, or as the content of aLayertoggled by aButton. See the stories under "DataFilters" for examples of each.Notes
This is just an initial draft to foster discussion.