[TS] fix: theme types of Button #6298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Aug 24, 2022
Comment on lines
+199
to
+205
| disabled?: | ||
| | (ButtonKindType & { | ||
| default?: ButtonKindType; | ||
| primary?: ButtonKindType; | ||
| secondary?: ButtonKindType; | ||
| }) | ||
| | ({ [key: string]: ButtonKindType } & { opacity?: OpacityType }); |
There was a problem hiding this comment.
Could we just have this?
Suggested change
| disabled?: | |
| | (ButtonKindType & { | |
| default?: ButtonKindType; | |
| primary?: ButtonKindType; | |
| secondary?: ButtonKindType; | |
| }) | |
| | ({ [key: string]: ButtonKindType } & { opacity?: OpacityType }); | |
| disabled?: ({ [key: string]: ButtonKindType } & { opacity?: OpacityType }); |
There was a problem hiding this comment.
This structure mimics the current structure for active and hover.
There was a problem hiding this comment.
Ok I'm fine moving forward with this then
ericsoderberghp
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the theme type of button.
Where should the reviewer start?
base.d.ts
What testing has been done on this PR?
local environment, tests
How should this be manually tested?
review the code
Do Jest tests follow these best practices?
N/A
Any background context you want to provide?
N/A
What are the relevant issues?
Follow up to a PR #5651 (I think)
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Nope, it's all bugs.
Should this PR be mentioned in the release notes?
Yes, as a TS fix
Is this change backward compatible or is it a breaking change?
backward compatible