Add weight prop to Heading #6294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeKingdom
reviewed
Aug 23, 2022
Comment on lines
+23
to
+24
| (data && data.maxWidth) || | ||
| levelStyle.medium.maxWidth}; |
There was a problem hiding this comment.
could use the indent. It's a little hard to read which styles are involved
There was a problem hiding this comment.
hmmm... let me see what I can do. I believe Prettier was forcing this.
There was a problem hiding this comment.
Something in the Prettier/ESLint space is forcing this onSave. I couldn't track down the rule / plugin causing this in a reasonable time. Okay with proceeding as is?
Comment on lines
+26
to
+27
| levelStyle.font.weight || | ||
| headingTheme.weight}; |
ericsoderberghp
approved these changes
Aug 23, 2022
jcfilben
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #6276 by adding
weightto<Heading />Where should the reviewer start?
Heading.js
What testing has been done on this PR?
Jest test suite, Storybook, plus new snapshot.
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6276
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes.
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.