Fix Select to load all options even when clear={true} #6285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Aug 19, 2022
jcfilben
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Looks good! I looked into the tests you added and was getting the same issue where the tests were timing out. I tried switching from userEvent to fireEvent and that seemed to solve the issue. Occasionally I've run across some cases where userEvent doesn't work as expected or affects the timing, so sometimes fireEvent is needed instead
halocline
reviewed
Aug 19, 2022
Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com>
halocline
approved these changes
Aug 19, 2022
ericsoderberghp
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
clearis used, all Select options still render (original issue filed)To Do:
User should be able to tab to the "Clear Selection" button if it is at the bottom.
In this video, I open the select with "space", use down arrow to move through the options, "enter" to select options", then "tab" to tab through the select options and get to "Clear Selection". I am using VoiceOver on Mac.
clear-bottom.mov
Where should the reviewer start?
SelectContainer
What testing has been done on this PR?
Using Clear story.
How should this be manually tested?
Use Clear story.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent. (userEvent was causing timeout, used fireEvent)asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6267
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
Yes. Fixed
clearbug where not all Select options would render.Is this change backwards compatible or is it a breaking change?
Backwards compatible.