Skip to content

omit border for table #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Jul 27, 2022

What does this PR do?

This PR omits the HTML table border

Where should the reviewer start?

DataTable/index.d.ts

What testing has been done on this PR?

locally

How should this be manually tested?

storybook

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

src/js/components/DataTable/index.d.ts:130:18 - error TS2320: Interface 'DataTableExtendedProps<TRowType>' cannot simultaneously extend types 'DataTableProps<TRowType>' and 'Omit<DetailedHTMLProps<TableHTMLAttributes<HTMLTableElement>, HTMLTableElement>, "placeholder" | "onSelect">'.
  Named property 'border' of types 'DataTableProps<TRowType>' and 'Omit<DetailedHTMLProps<TableHTMLAttributes<HTMLTableElement>, HTMLTableElement>, "placeholder" | "onSelect">' are not identical.

since we are extending our DataTable props while vomiting some of the html table props there was an issue with border

What are the relevant issues?

closes #6236

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

sure

Is this change backwards compatible or is it a breaking change?

backwards compatible

@britt6612 britt6612 requested a review from taysea July 27, 2022 19:25
@taysea taysea requested a review from ericsoderberghp July 27, 2022 20:16
@ericsoderberghp ericsoderberghp merged commit df0d9b9 into grommet:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TS] type issue in DataTable/index.d.ts
3 participants