fix: menu types and added 'button' prop for menu theme #6241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Jul 20, 2022
jcfilben
reviewed
Jul 21, 2022
| @@ -336,6 +337,7 @@ const Menu = forwardRef((props, ref) => { | |||
| justify={item.justify} | |||
| kind={!child ? 'option' : undefined} | |||
| hoverIndicator={!child ? undefined : 'background'} | |||
| {...theme.menu.item} | |||
There was a problem hiding this comment.
This looks like the theme would override justify={item.justify} above. I'mm wondering if we should more generally merge properties, via something like:
const defaultItemProps = { align: 'start' };
...
<Button {{ ...defaultItemProps, ...theme.menu.item, ...item }} \>
Does that make any sense, or am I missing something?
There was a problem hiding this comment.
Agreed. I changed the order of the assignment, let me know if that works.
ericsoderberghp
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Suggests a clean way for generic styles on Menu's item-buttons via theme. Applying the styles (on both default + mirror rendering) helps declutter lots of inline styles per Menu item.
Improve types of Menu (item type, theme.menu.drop type, etc), the existing Stroybook Menu 'Themed' example is throwing an error due to the
onClickof the Menu item:Extending Menu 'Themed' story with the new prop
Where should the reviewer start?
Menu.js
What testing has been done on this PR?
storybook - check the enhanced story
How should this be manually tested?
storybook
Do Jest tests follow these best practices?
N/A
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
The new prop will help clean up a lot of inline styles within Menu items.
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes.
Should this PR be mentioned in the release notes?
Yes, will be helpful for Menu users and TS users.
Is this change backward compatible or is it a breaking change?
backward compatible