[Typescript] Support focus shadow as a string #6234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports the theme's
focus.shadow
to accept a string.Where should the reviewer start?
theme file with types
What testing has been done on this PR?
local tests.
How should this be manually tested?
locally.
Do Jest tests follow these best practices?
N/A
Any background context you want to provide?
On src/js/utils/styles.js we use:
and since
box-shadow
accepts the type of string, it should be accepted as a valid input type as well.What are the relevant issues?
#5446
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Where are the global theme types are documented? the new type should be added there.
Should this PR be mentioned in the release notes?
yep, as a TS fix.
Is this change backward compatible or is it a breaking change?
backward compatible