Skip to content

update digital clock type to avoid type conflict when bumping grommet 2.17.15 => 2.25 #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

update digital clock type to avoid type conflict when bumping grommet 2.17.15 => 2.25 #6220

merged 2 commits into from
Jul 11, 2022

Conversation

tol-any
Copy link
Contributor

@tol-any tol-any commented Jul 5, 2022 •
edited
Loading

Fix #6219

@tol-any tol-any changed the title fixes #6219 update type to avoid type conflict when bumping grommet 2.17.15 => 2.25 update digital clock type to avoid type conflict when bumping grommet 2.17.15 => 2.25 Jul 5, 2022
jcfilben
jcfilben approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcfilben jcfilben requested a review from ericsoderberghp July 7, 2022 19:00
@ericsoderberghp ericsoderberghp merged commit 58328d6 into grommet:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfilben jcfilben jcfilben approved these changes

+1 more reviewer

@ericsoderberghp ericsoderberghp ericsoderberghp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript issues when trying to upgrade from grommet 2.17.5 to 2.25 in react 17
3 participants
@tol-any @ericsoderberghp @jcfilben