You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Calendar could not handle Daylight Savings Time properly because it relied on ISOstring to infer timezone, however ISOstring only contains information related to UTC offset, but the actual timezone information is lost. See comment for more detail.
This PR refactors Calendar rely on Date object as opposed to ISO strings.
Calendar accepts ISOstrings as input --> normalizes the inputs as Date objects --> all logic is handled as Date objects --> only normalizes output supplied to onSelect as last step, returning dates as ISOstrings.
Additionally, to reduce complexity, consolidate logic, and improve control flow, this PR makes the following adjustments:
Internally, date and dates both feed an internal variable called value. API surface remains the same. All logic consider value to be either a Date object, an array of Date objects, a nested array of Date objects, or undefined.
taysea
added
bug
issue that does not match design or documentation and requires code changes to address
accessibility
WCAG support
and removed
bug
issue that does not match design or documentation and requires code changes to address
accessibility
WCAG support
labels
Jun 30, 2022
The reason will be displayed to describe this comment to others. Learn more.
It looks like I am no longer able to change the date on Calendars that don't have onSelect defined. (See Calendar/First on Sunday and Daylight Savings stories)
It looks like I am no longer able to change the date on Calendars that don't have onSelect defined. (See Calendar/First on Sunday and Daylight Savings stories)
we should confirm, as a team, that that's desired behavior.
Ah okay that makes sense. I think that behavior is reasonable, we should just to be sure to call this out in the release notes since before we weren't enforcing this
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, Calendar could not handle Daylight Savings Time properly because it relied on ISOstring to infer timezone, however ISOstring only contains information related to UTC offset, but the actual timezone information is lost. See comment for more detail.
This PR refactors Calendar rely on Date object as opposed to ISO strings.
dateanddatesboth feed an internal variable calledvalue. API surface remains the same. All logic considervalueto be either a Date object, an array of Date objects, a nested array of Date objects, or undefined.Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6043
Closes #6044
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible + some bug fixes