Changed DataChart to fix an issue with detail padding. #6206
Conversation
There was a problem hiding this comment.
Code looks good
Just a clarification question. It looks like this is working well when the chart.thickness is equal to the pad.horizontal value. If we wanted a chart with a 'xlarge' pad but with 'small' thickness for the bars is there a way to achieve this with the detail correctly aligned? Or would this be a separate issue/PR?
Good idea. I've updated it to handle pad and thickness better. |
What does this PR do?
Changed DataChart to fix an issue with detail padding.
Where should the reviewer start?
code
What testing has been done on this PR?
Added a "Pad" story
How should this be manually tested?
"Pad" story
Do Jest tests follow these best practices?
no changes to unit tests, not sure how to test detail interaction via jest
What are the relevant issues?
#6197
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible