Adjust menu grouped separator #6201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Jun 22, 2022
src/js/components/Menu/Menu.js
Outdated
| <Box | ||
| margin={{ | ||
| horizontal: 'small', | ||
| bottom: index === 0 ? 'none' : 'small', |
There was a problem hiding this comment.
The container of the group already has vertical padding. It doesn't feel like we need to add this bottom margin also.
There was a problem hiding this comment.
Fixed in latest commit
taysea
reviewed
Jun 22, 2022
taysea
reviewed
Jun 22, 2022
taysea
reviewed
Jun 23, 2022
src/js/components/Menu/Menu.js
Outdated
|
|
||
| return menuItem(item, currentIndex); | ||
| })} | ||
| <Box pad={theme.menu.group.separator.pad}> |
There was a problem hiding this comment.
Should we change where the groupIndex > 0 condition is placed and only render this entire Box when groupIndex > 0 ?
There was a problem hiding this comment.
Good idea, changed this in the latest commit
taysea
reviewed
Jun 23, 2022
ericsoderberghp
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjusts the Menu grouped separator to have the same amount of padding/margin as the menu options.
Where should the reviewer start?
What testing has been done on this PR?
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent. (Note I had to use firEvent instead of userEvent for the down arrow. User Event wasn't opening the menu)asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6188
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes
Should this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
Backwards compatible