Changed Meter to handle floating point precision issues better #6191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some truncation to deal with floating point precision issues in javascript.
From the test case shown below,
2.26 + 8.04 === 10.299999999999999
instead of10.3
.See this post for some details on the underlying shortcomings of javascript: https://stackoverflow.com/questions/1458633/how-to-deal-with-floating-point-number-precision-in-javascript
Where should the reviewer start?
Meter.js
What testing has been done on this PR?
The test scenario from the issue involves:
A unit test has been added.
How should this be manually tested?
see ^^^
Do Jest tests follow these best practices?
follows existing test patterns
What are the relevant issues?
#6190
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible