Fixed incorrect row highlight behavior #6189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
approved these changes
Jun 16, 2022
jcfilben
reviewed
Jun 16, 2022
There was a problem hiding this comment.
In the DataTable/Clickable story if I only use the keyboard to navigate I can't get to any of the options (open the story, press tab to get focus on the DataTable, and then try to navigate through options with the up and down arrows). Only after clicking an option am I able to use the keyboard to navigate to other options.
good catch thinking that was the reasoning behind the |
ericsoderberghp
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect highlighting of the first row in a table after selecting another item, clicking outside of the table, and trying to select a disabled row. Looked into the "pinnable" highlight behavior noted in the issue but could be a separate issue (not sure of the expected behavior vs. actual behavior).
Where should the reviewer start?
Body.js
What testing has been done on this PR?
Manual testing
How should this be manually tested?
Use the onSelect story in Storybook
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6165
Screenshots (if appropriate)
Video Showing Issue
Screen.Recording.2022-06-16.at.12.44.55.PM.mov
Video Showing Fix
Screen.Recording.2022-06-16.at.12.33.45.PM.mov
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
Compatible