Changed DataChart to improve how swatches are rendered for detail and legend #6173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed DataChart to improve how swatches are rendered for detail and legend.
The key concept is that instead of always drawing a path and filling it, we now draw a line and style the stroke to align better with how the Chart renders.
Where should the reviewer start?
DataChart.js
What testing has been done on this PR?
Check Detail and Legend stories.
Enhanced Legend story to include dash and round.
Verified that unit test snapshots changes are expected.
How should this be manually tested?
Detail and Legend stories
Do Jest tests follow these best practices?
no test changes
What are the relevant issues?
#6119
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible