Allowing to reverse icon in DateInput #6160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
May 27, 2022
There was a problem hiding this comment.
Just a few notes:
-
We should support both passing the reverse prop through
inputPropsand having thereverseprop on DateInput. Ideally just using thereverseprop is preferred but we need to support passing reverse throughinputPropsfor backwards compatibility since we supported this in the past. See https://github.com/grommet/grommet/pull/6160/files for a similar discussion about the icon prop on DateInput. -
When the icon is on the left side of DateInput the tab order is messed up. The focus moves first to the input and then the icon. It should move to the icon first and then the input since that is how it is visually ordered.
amandadupell
approved these changes
Jun 6, 2022
jcfilben
reviewed
Jun 6, 2022
3042aa4 to
5f25beb
Compare
ericsoderberghp
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed issue #6153 which consists of allowing to reverse icon in DateInput.
Where should the reviewer start?
Just access:
http://localhost:9001/?path=/story/input-dateinput-format--format
What testing has been done on this PR?
Unit test to Match Snapshot.
How should this be manually tested?
It is not necessary
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
No
What are the relevant issues?
No
Screenshots
Do the grommet docs need to be updated?
Yes, to add the new DateInput prop,
reverseShould this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
No