Fix onChange type for FileInput #6145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt6612
reviewed
May 23, 2022
| @@ -22,10 +22,11 @@ export interface FileInputProps { | |||
| }; | |||
| multiple?: boolean | { aggregateThreshold?: number; max?: number }; | |||
| name?: string; | |||
| onChange?: (event?: any, { files }?: { files: any }) => void; | |||
There was a problem hiding this comment.
is there anything more specific than any
There was a problem hiding this comment.
Good comment, just updated this to make the types more specific
britt6612
approved these changes
May 24, 2022
ericsoderberghp
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the typescript definition for onChange in FileInput
Where should the reviewer start?
What testing has been done on this PR?
Tested with the following code in a typescript story:
and
with
<FileInput onChange={onChange} />How should this be manually tested?
Test an
onChangefunction with FileInput in a typescript fileDo Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6143
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Maybe
Is this change backwards compatible or is it a breaking change?
Backwards compatible