Changed Notification to pass through additional properties #6139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible for this PR to resolve this issue as well? |
jcfilben
reviewed
May 20, 2022
Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
…ommet into fix/notification-rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed Notification to pass through additional properties.
These changes were necessary for grommet-designer:
status, which occurs when the user is editing the statusonClickandstyle.Where should the reviewer start?
Notification.js
What testing has been done on this PR?
added a unit test
built and tested in a local instance of grommet-designer
Do Jest tests follow these best practices?
asFragment()is used for snapshot testing.Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible