Skip to content

Conversation

britt6612
Copy link
Collaborator

What does this PR do?

This PR reverts
"babel-plugin-styled-components": "2.0.6",

Where should the reviewer start?

package.json

What testing has been done on this PR?

yarn test update

How should this be manually tested?

n/a

Do Jest tests follow these best practices?

n/a

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

With this update, there were snapshot changes that were being made
which is affecting any new PRs that are being made. Need to look further into why upgrading this package would include snapshot changes

What are the relevant issues?

none

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

no

Is this change backwards compatible or is it a breaking change?

backward compatible

@britt6612 britt6612 requested a review from jcfilben May 4, 2022 20:16
@jcfilben jcfilben requested a review from ericsoderberghp May 4, 2022 21:05
@britt6612 britt6612 mentioned this pull request May 4, 2022
4 tasks
@ericsoderberghp ericsoderberghp merged commit 8200726 into grommet:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants