Fix #6981 #6987
Closed
Fix #6981 #6987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)$/; to const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)(?![\w-])$/; hacktoberfest
MikeKingdom
reviewed
Oct 23, 2023
| @@ -157,7 +157,7 @@ export const makeNodeFocusable = (node) => { | |||
| } | |||
| }; | |||
|
|
|||
| const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)$/; | |||
| const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)(?![\w-])$/; | |||
There was a problem hiding this comment.
This RE still matches tags like meta. What is your addition trying to do? I would think a fix would be anchoring the beginning. For example:
const autoFocusingTags = /^(a|area|input|select|textarea|button|iframe)$/;|
Hey @aditya000099 just wanted to check in on this PR, are you interested in revisiting it? If not I think we can close this. |
|
Closing due to inactivity. Feel free to re-open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)$/; to const autoFocusingTags = /(a|area|input|select|textarea|button|iframe)(?![\w-])$/;
hacktoberfest