Skip to content

Conversation

britt6612
Copy link
Collaborator

What does this PR do?

update searchPlaceholder to take a node as well as a string

Where should the reviewer start?

select/index.d.ts

What testing has been done on this PR?

How should this be manually tested?

searchPlaceholder functionally takes a node as well as a string so should we support this?

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

I want search icon and placeholder text in search input field.
But searchPlaceholder accept only string value and I want both search Icon and placeholder both like below screenshot
How to do that? (edited) 

https://codesandbox.io/s/competent-merkle-q908cc?file=/src/App.js

What are the relevant issues?

none

Screenshots (if appropriate)

Do the grommet docs need to be updated?

yes

Should this PR be mentioned in the release notes?

maybe

Is this change backwards compatible or is it a breaking change?

backwards compatible

@britt6612 britt6612 requested a review from jcfilben May 23, 2023 17:12
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcfilben jcfilben merged commit 6cfa2ee into grommet:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants