Added DataTableGroupBy #6749
Merged
Added DataTableGroupBy #6749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Apr 14, 2023
taysea
reviewed
Apr 14, 2023
jcfilben
reviewed
Apr 14, 2023
There was a problem hiding this comment.
This comment is outside the scope of this PR, but I'm wondering if we should revisit the styling for grouping in a DataTable. When I grouped by 'percent complete' in this example I felt that the grouping styling wasn't distinct enough to be helpful in visually parsing the data.
There was a problem hiding this comment.
Agreed. But, I'm thinking that should be a separate pull request.
jcfilben
reviewed
Apr 14, 2023
| @@ -0,0 +1,5 @@ | |||
| let PropType = {}; | |||
| if (process.env.NODE_ENV !== 'production') { | |||
| PropType = {}; | |||
There was a problem hiding this comment.
Looks like we are missing options here
There was a problem hiding this comment.
added propTypes
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added DataTableGroupBy
Where should the reviewer start?
DataTableGroupBy.js
What testing has been done on this PR?
added a story
added a simple unit test
How should this be manually tested?
story
Do Jest tests follow these best practices?
followed other Data tests for now
Any background context you want to provide?
What are the relevant issues?
#6733
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible