Add Default Tooltip to DataTableColumns #6746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Apr 18, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds default tooltip using
messagesand contexts defined in DataTableColumns.js.Updated the DataTableColumns
Simplestory - AddsDataSearchbelow the Toolbar, which matches the pattern in the Data/DataTable story, allowing for the DataTableColumns tip to not overlap with content in the DataTable.Where should the reviewer start?
src/js/components/DataTableColumns/DataTableColumns.js
src/js/components/DataTableColumns/stories/Simple.js
What testing has been done on this PR?
Manual + visual testing
How should this be manually tested?
Ensure that DataTable functionality remains the same. Also, visually test for if the DataTableColumns tip overlaps with any content.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
Following up, the current message is "Open column selector". Guidance on the Design Site here indicates that the message should be "Manage Columns".
What are the relevant issues?
Closes #6743.
Screenshots (if appropriate)
DataSearch components creates the space for the tip to occupy, otherwise, the tip overflows into the table content.Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible