Changed DataTable to use a primaryKey value as the row key #6742
Conversation
|
Something funky is happening in this storybook example. The location is showing up in the "Name" column |
I reproduced by interacting with the storybook example on Chrome. Seemed to only be an issue when interacting with DataTableColumns -> selecting/deselecting the Name column. |
|
The story issue was caused by the DataTableColumns Simple story not setting |
|
Thanks for doing this. Will there be a grommet release in the next couple of weeks that includes this fix? |
We should have a release coming roughly within ~1 week |
What does this PR do?
Changed DataTable to use a primaryKey value as the row key
Where should the reviewer start?
one line changed
What testing has been done on this PR?
unit tests
How should this be manually tested?
storybook?
Do Jest tests follow these best practices?
no change to test structure
Any background context you want to provide?
What are the relevant issues?
#6688
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible when using primaryKey
if the caller has no column.primary or primaryKey and the first value in the data objects is not unique, the browser will display a warning. This is expected given the inputs.