Skip to content

Conversation

halocline
Copy link
Collaborator

What does this PR do?

Fixes #6716 by ensuring align gets passed to Grid.

Where should the reviewer start?

NameValueList.js

What testing has been done on this PR?

Storybook

How should this be manually tested?

Add some Grid props to .../NameValueList/Simple such as:

<NameValueList
          align="center"
          justify="center"
          gap={{ row: 'large', column: 'xlarge' }}
        >
...

Do Jest tests follow these best practices?

  • screen is used for querying.
  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.

Any background context you want to provide?

What are the relevant issues?

#6716

Screenshots (if appropriate)

Do the grommet docs need to be updated?

No

Should this PR be mentioned in the release notes?

Yes.

Is this change backwards compatible or is it a breaking change?

Backwards compatible.

@halocline halocline requested a review from jcfilben March 31, 2023 23:30
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcfilben jcfilben requested a review from taysea April 3, 2023 18:59
@jcfilben jcfilben merged commit bcf727d into grommet:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameValuePair alignment
3 participants