Skip to content

Conversation

ericsoderberghp
Copy link
Contributor

What does this PR do?

Changed DataFilters to use tip.

Where should the reviewer start?

DataFilters.js

What testing has been done on this PR?

storybook

How should this be manually tested?

storybook

Do Jest tests follow these best practices?

no test changes

Any background context you want to provide?

What are the relevant issues?

#6694

Screenshots (if appropriate)

Screenshot 2023-03-24 at 3 43 21 PM

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

yes

Is this change backwards compatible or is it a breaking change?

backwards compatible

@ericsoderberghp ericsoderberghp linked an issue Mar 24, 2023 that may be closed by this pull request
Copy link
Collaborator

@MikeKingdom MikeKingdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@JCoder121 JCoder121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ericsoderberghp ericsoderberghp merged commit 52e3c86 into master Mar 27, 2023
@ericsoderberghp ericsoderberghp deleted the fix/datafilters-tip branch March 27, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFilters Default Tooltip
3 participants