Data Array Enhancement #6704
Merged
Data Array Enhancement #6704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Mar 24, 2023
taysea
reviewed
Mar 24, 2023
taysea
reviewed
Mar 24, 2023
taysea
reviewed
Mar 24, 2023
taysea
reviewed
Mar 24, 2023
|
Something looks off with the vertical alignment here. I don't think this is related to the changes in this pull request but wondering if you can take a quick look. |
|
Can you enhance the story so that searching matches on the color names, in addition to the filtering? |
|
I think we should consider using |
|
ericsoderberghp
approved these changes
Mar 24, 2023
4 tasks
12 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex Story Deploy Preview
What does this PR do?
Add functionality to Data's
filter()for when a property is alist, rather than astring,bool, or nested object. Allow the user to select filter values that filter upon list objects.Where should the reviewer start?
src/js/components/Data/filter.js
src/js/components/Data/stories/Complex.js
What testing has been done on this PR?
Manual and visual testing to ensure filtering upon list elements works as intended.
How should this be manually tested?
Check that existing filtering works as expected in addition to the new list filtering capabilities.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6701
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes - update after initial code review to include example case.
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?