Fixed some issues with using grommet in a shadow root #6698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like how in the current storybook, the theme selector says "Theme" -- I was expecting something similar in the deploy that said "Root". I noticed it's changed to say "grommet" and "document" which I didn't immediately recognize as a selector. soft opinion. NOW |
taysea
reviewed
Mar 22, 2023
changed as suggested, I was soft too :) |
MikeKingdom
approved these changes
Mar 23, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses some issues with using grommet inside a shadow root context. Specifically, too much reliance on
documentbeing the root of things.Also, added a "document" vs. "shadow" toolbar control in storybook to allow testing any story from a shadow root context.
Where should the reviewer start?
DropContainer.js
What testing has been done on this PR?
Various stories with the new shadow root context, certainly not all though.
How should this be manually tested?
stories with shadow root context
Do Jest tests follow these best practices?
no test changes
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible